- Group Reviewers
- rSTAGING5d6c493547fe: [CMAKE] Refactor the AddCompilerFlags facilities
rABC5d6c493547fe: [CMAKE] Refactor the AddCompilerFlags facilities
mkdir buildcmake && cd buildcmake cmake -GNinja .. ninja check
Looks good overall, but it looks like there are leftovers.
|19 ↗||(On Diff #10609)|
By convention, private construct are prefixed with _ .
|80 ↗||(On Diff #10609)|
This check is redundant as add_compiler_flags_to_var already does it.
|84 ↗||(On Diff #10609)|
You probably want to call add_compiler_flags_to_var unconditionally here.