Differential D3827

[CMAKE] Make secp256k1 build standalone
ClosedPublic
Actions

Authored by Fabien on Aug 8 2019, 14:46.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING82496919fa53: [CMAKE] Make secp256k1 build standalone
rABC82496919fa53: [CMAKE] Make secp256k1 build standalone

Summary

The current cmake build doesn't allow for building secp256k1 standalone.
This diff fixes this.

Test Plan

cd src/secp256k1
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_secp256k1_standalone

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7082
Build 12210: Bitcoin ABC Buildbot (legacy)
Build 12209: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 8 2019, 14:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 8 2019, 14:46

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7082: Diff 10674.Aug 8 2019, 14:56

deadalnix accepted this revision.Aug 12 2019, 05:57

This revision is now accepted and ready to land.Aug 12 2019, 05:57

Closed by commit rABC82496919fa53: [CMAKE] Make secp256k1 build standalone (authored by Fabien). · Explain WhyAug 13 2019, 07:56

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC82496919fa53: [CMAKE] Make secp256k1 build standalone.

Fabien added a commit: rSTAGING82496919fa53: [CMAKE] Make secp256k1 build standalone.Sep 19 2019, 01:47

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

CMakeLists.txt

14 lines

Diff 10674

View Options

src/secp256k1/CMakeLists.txt

[CMAKE] Make secp256k1 build standaloneClosedPublicActions