Page MenuHomePhabricator

Disable wallet and address book Qt tests on macOS minimal platform
ClosedPublic

Authored by Fabien on Thu, Aug 22, 10:02.

Details

Summary
macOS Qt minimal platform is frequently broken, and these are currently
failing with Qt 5.11.1.

The tests do pass when run on the full cocoa platform
(with `test_bitcoin-qt -platform cocoa`).

Backport of core PR14011
https://github.com/bitcoin/bitcoin/pull/14011/files

This was improperly backported in D2054.
Expected to fix issue #340:
https://github.com/Bitcoin-ABC/bitcoin-abc/issues/340

Test Plan

On OSX with minimal platform (default):

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Thu, Aug 22, 10:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Aug 22, 10:02
deadalnix added inline comments.Thu, Aug 22, 18:01
src/qt/test/wallettests.cpp
116 ↗(On Diff #10922)

Why is this removed ? This isn't part of the original PR.

Fabien added inline comments.Thu, Aug 22, 18:17
src/qt/test/wallettests.cpp
116 ↗(On Diff #10922)

The fix has already been backported in D2054, but not at the same place than the original PR.
I moved it to make it consistent with core, there is no functional change.

deadalnix accepted this revision.Fri, Aug 23, 15:03
This revision is now accepted and ready to land.Fri, Aug 23, 15:03