Page MenuHomePhabricator

Disable wallet and address book Qt tests on macOS minimal platform

Authored by Fabien on Aug 22 2019, 10:02.


macOS Qt minimal platform is frequently broken, and these are currently
failing with Qt 5.11.1.

The tests do pass when run on the full cocoa platform
(with `test_bitcoin-qt -platform cocoa`).

Backport of core PR14011

This was improperly backported in D2054.
Expected to fix issue #340:

Test Plan

On OSX with minimal platform (default):

make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Aug 22 2019, 10:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 22 2019, 10:02
deadalnix added inline comments.Aug 22 2019, 18:01
116 ↗(On Diff #10922)

Why is this removed ? This isn't part of the original PR.

Fabien added inline comments.Aug 22 2019, 18:17
116 ↗(On Diff #10922)

The fix has already been backported in D2054, but not at the same place than the original PR.
I moved it to make it consistent with core, there is no functional change.

deadalnix accepted this revision.Aug 23 2019, 15:03
This revision is now accepted and ready to land.Aug 23 2019, 15:03