Disable wallet and address book Qt tests on macOS minimal platform
ClosedPublic
Actions

Authored by Fabien on Aug 22 2019, 10:02.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGcde47be6adbf: Disable wallet and address book Qt tests on macOS minimal platform
rABCcde47be6adbf: Disable wallet and address book Qt tests on macOS minimal platform

Summary

macOS Qt minimal platform is frequently broken, and these are currently
failing with Qt 5.11.1.

The tests do pass when run on the full cocoa platform
(with `test_bitcoin-qt -platform cocoa`).

Backport of core PR14011
https://github.com/bitcoin/bitcoin/pull/14011/files

This was improperly backported in D2054.
Expected to fix issue #340:
https://github.com/Bitcoin-ABC/bitcoin-abc/issues/340

Test Plan

On OSX with minimal platform (default):

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 22 2019, 10:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 22 2019, 10:02

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7224: Diff 10922.Aug 22 2019, 10:09

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix added inline comments.Aug 22 2019, 18:01

src/qt/test/wallettests.cpp
116 ↗	(On Diff #10922)	Why is this removed ? This isn't part of the original PR.

Fabien added inline comments.Aug 22 2019, 18:17

src/qt/test/wallettests.cpp
116 ↗	(On Diff #10922)	The fix has already been backported in D2054, but not at the same place than the original PR. I moved it to make it consistent with core, there is no functional change.