Page MenuHomePhabricator

Fix deprecated copy warnings in amount.h
ClosedPublic

Authored by deadalnix on Aug 28 2019, 16:41.

Details

Summary

This is a warning that is enabled by default on modern versions of GCC. Out code is tripping this in the Amount class.

Test Plan

Build and ensure that warnings in Amount when building with GCC9.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Aug 28 2019, 16:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2019, 16:41
deadalnix updated this revision to Diff 11042.Aug 30 2019, 13:00

Remove flags twiddling

deadalnix retitled this revision from Enable deprecated copy warnings to Fix deprecated copy warnings in amount.h.Aug 30 2019, 13:06
deadalnix edited the summary of this revision. (Show Details)
Fabien accepted this revision.Aug 30 2019, 13:07
This revision is now accepted and ready to land.Aug 30 2019, 13:07
This revision was landed with ongoing or failed builds.Aug 30 2019, 13:11
This revision was automatically updated to reflect the committed changes.