Paths

Table of Contentst

Differential D3969

Fix shellcheck version >= 0.5.0 errors
ClosedPublic
Actions

Authored by Fabien on Aug 29 2019, 11:25.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING44b24abfda04: Fix shellcheck version >= 0.5.0 errors
rABC44b24abfda04: Fix shellcheck version >= 0.5.0 errors

Summary

The linter will throw warnings and errors with shellcheck versions >=
0.5.

Backport of core PR16327 (which implies PR14115, PR15164 and PR15166)
https://github.com/bitcoin/bitcoin/pull/16327/files

https://github.com/bitcoin/bitcoin/pull/14115/files
https://github.com/bitcoin/bitcoin/pull/15164/files
https://github.com/bitcoin/bitcoin/pull/15166/files

Note that the rule SC1117 (from PR14115) is still excluded as it would
throw false positives. It has been removed from shellcheck versions >
0.5.0, but I kept it for compatibility with previous versions (i.e.
Debian buster has 0.5.0).
See https://github.com/koalaman/shellcheck/wiki/SC1117 for details.

Test Plan

Install the latest shellcheck (currently 0.7.0).
Check arc lint --everything returns no error.
Tested with versions 0.4.4, 0.4.6, 0.5.0 and 0.7.0.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR16327

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7276
Build 12597: Bitcoin ABC Buildbot (legacy)
Build 12596: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 29 2019, 11:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 29 2019, 11:25

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7276: Diff 11018.Aug 29 2019, 11:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Aug 29 2019, 11:37

This revision is now accepted and ready to land.Aug 29 2019, 11:37

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Closed by commit rABC44b24abfda04: Fix shellcheck version >= 0.5.0 errors (authored by Fabien). · Explain WhyAug 29 2019, 12:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC44b24abfda04: Fix shellcheck version >= 0.5.0 errors.

Fabien added a commit: rSTAGING44b24abfda04: Fix shellcheck version >= 0.5.0 errors.Sep 19 2019, 02:04

Revision Contents
Changeset List

Path

Size

arcanist/

.phutil_module_cache

2 lines

linter/

ShellCheckLinter.php

14 lines

4 lines

contrib/

devtools/

gen-manpages.sh

2 lines

gitian/

4 lines

macdeploy/

detached-sig-apply.sh

6 lines

detached-sig-create.sh

14 lines

qos/

4 lines

teamcity/

build-configurations.sh

2 lines

build-secp256k1.sh

5 lines

16 lines

4 lines

2 lines

verifybinaries/

11 lines

share/

4 lines

src/

qt/

res/

movies/

2 lines

test/

functional/

test_framework/

tests/

run_self_tests.sh

4 lines

Diff 11018

arcanist/.phutil_module_cache

Loading...

arcanist/linter/ShellCheckLinter.php

Loading...

autogen.sh

Loading...

contrib/devtools/gen-manpages.sh

Loading...

contrib/gitian/provisioner.sh

Loading...

contrib/macdeploy/detached-sig-apply.sh

Loading...

contrib/macdeploy/detached-sig-create.sh

Loading...

contrib/qos/tc.sh

Loading...

contrib/teamcity/build-configurations.sh

Loading...

contrib/teamcity/build-secp256k1.sh

Loading...

contrib/teamcity/build.sh

Loading...

contrib/teamcity/gitian.sh

Loading...

contrib/teamcity/ibd.sh

Loading...

contrib/verifybinaries/verify.sh

Loading...

share/genbuild.sh

Loading...

src/qt/res/movies/makespinner.sh

Loading...

test/functional/test_framework/tests/run_self_tests.sh

Loading...