Differential D4000

Increase LevelDB max_open_files unless on 32-bit Unix.
ClosedPublic
Actions

Authored by Fabien on Sep 5 2019, 09:21.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
fpelliccioni

Group Reviewers

Restricted Project

Commits

rSTAGING6fd148b321c6: Increase LevelDB max_open_files unless on 32-bit Unix.
rABC6fd148b321c6: Increase LevelDB max_open_files unless on 32-bit Unix.

Summary

This change significantly increases IBD performance by increasing the
amount of the UTXO index that can remain in memory. To ensure this
doesn't cause problems in the future, a static_assert on the LevelDB
version has been added, which must be updated by anyone upgrading
LevelDB.

Backport of core PR12495
https://github.com/bitcoin/bitcoin/pull/12495/files

Test Plan

Run IBD on CI (and expect a significant performace improvement).

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 5 2019, 09:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2019, 09:21

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) started.

Started IBD on this diff: https://build.bitcoinabc.org/viewLog.html?tab=buildLog&buildTypeId=BitcoinABC_ResourceIntensiveBuilds_BitcoinAbcIbdDiffTestingWOCheckpoints&buildId=18634
I will request for review when it ends successfully.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7325: Diff 11093.Sep 5 2019, 09:28

Code seems good to me. Awaiting for the IBD result.

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) passed.

IBD was successful (w/o checkpoint). Duration was ~7h, against ~9h before the patch :)

This revision is now accepted and ready to land.Sep 5 2019, 19:55

Closed by commit rABC6fd148b321c6: Increase LevelDB max_open_files unless on 32-bit Unix. (authored by Evan Klitzke <evan@eklitzke.org>, committed by Fabien). · Explain WhySep 6 2019, 07:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6fd148b321c6: Increase LevelDB max_open_files unless on 32-bit Unix..

Fabien added a commit: rSTAGING6fd148b321c6: Increase LevelDB max_open_files unless on 32-bit Unix..Sep 19 2019, 02:08

Revision Contents
Changeset List

Path

Size

doc/

developer-notes.md

51 lines

src/

27 lines

Diff 11120

doc/developer-notes.md

Loading...

src/dbwrapper.cpp

Loading...