Page MenuHomePhabricator

Increase LevelDB max_open_files unless on 32-bit Unix.
ClosedPublic

Authored by Fabien on Thu, Sep 5, 09:21.

Details

Summary
This change significantly increases IBD performance by increasing the
amount of the UTXO index that can remain in memory. To ensure this
doesn't cause problems in the future, a static_assert on the LevelDB
version has been added, which must be updated by anyone upgrading
LevelDB.

Backport of core PR12495
https://github.com/bitcoin/bitcoin/pull/12495/files

Test Plan

Run IBD on CI (and expect a significant performace improvement).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Thu, Sep 5, 09:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Sep 5, 09:21
fpelliccioni accepted this revision as: fpelliccioni.Thu, Sep 5, 13:18

Code seems good to me. Awaiting for the IBD result.

Fabien requested review of this revision.Thu, Sep 5, 19:55

IBD was successful (w/o checkpoint). Duration was ~7h, against ~9h before the patch :)

This revision is now accepted and ready to land.Thu, Sep 5, 19:55