Bugfix: NSIS: Exclude Makefile* from docs
ClosedPublic
Actions

Authored by Fabien on Sep 6 2019, 15:28.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGa62f4554ef1b: Bugfix: NSIS: Exclude Makefile* from docs
rABCa62f4554ef1b: Bugfix: NSIS: Exclude Makefile* from docs

Summary

Otherwise, the generated Makefile is included in the NSIS-installed
documentation, which can lead to non-determinism (eg, if gawk is
installed on some build VMs, but others only have mawk)

Backport of core PR14018
https://github.com/bitcoin/bitcoin/pull/14018/files

I was hoping that it would make the gitian windows build deterministic
but it is not enough. Still good to backport anyway.

Test Plan

Run the windows gitian builds.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 6 2019, 15:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2019, 15:28

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7344: Diff 11126.Sep 6 2019, 15:39

jasonbcox accepted this revision.Sep 6 2019, 15:50

This revision is now accepted and ready to land.Sep 6 2019, 15:50

Closed by commit rABCa62f4554ef1b: Bugfix: NSIS: Exclude Makefile* from docs (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by Fabien). · Explain WhySep 8 2019, 09:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa62f4554ef1b: Bugfix: NSIS: Exclude Makefile* from docs.

Fabien added a commit: rSTAGINGa62f4554ef1b: Bugfix: NSIS: Exclude Makefile* from docs.Sep 19 2019, 02:11

Revision Contents
Changeset List

Path

Size

share/

setup.nsi.in

2 lines

Diff 11154

View Options

Bugfix: NSIS: Exclude Makefile* from docsClosedPublicActions