Page MenuHomePhabricator

Bugfix: NSIS: Exclude Makefile* from docs
ClosedPublic

Authored by Fabien on Fri, Sep 6, 15:28.

Details

Summary
Otherwise, the generated Makefile is included in the NSIS-installed
documentation, which can lead to non-determinism (eg, if gawk is
installed on some build VMs, but others only have mawk)

Backport of core PR14018
https://github.com/bitcoin/bitcoin/pull/14018/files

I was hoping that it would make the gitian windows build deterministic
but it is not enough. Still good to backport anyway.

Test Plan

Run the windows gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Fri, Sep 6, 15:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Sep 6, 15:28
jasonbcox accepted this revision.Fri, Sep 6, 15:50
This revision is now accepted and ready to land.Fri, Sep 6, 15:50
This revision was automatically updated to reflect the committed changes.