Page MenuHomePhabricator

Integration of property based testing into Bitcoin Core
AbandonedPublic

Authored by fpelliccioni on Sep 13 2019, 20:23.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Summary

This PR is a subset of the changes in #8469. It's meant to be easier to review. This PR contains all of the build instructions needed for travis to pass. It includes one property call key_properties.cpp along with a generator file called crypto_gen.{h,cpp}.

Backport of Bitcoin Core PR12775
https://github.com/bitcoin/bitcoin/pull/12775

Test Plan

I left it untested, due to the difficulty of it.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-eea87ef53
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7451
Build 12945: Bitcoin ABC Buildbot (legacy)
Build 12944: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 13 2019, 20:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2019, 20:23
deadalnix requested changes to this revision.Sep 14 2019, 07:51

The test plan is not appropriate.

This revision now requires changes to proceed.Sep 14 2019, 07:51
fpelliccioni planned changes to this revision.Sep 17 2019, 17:08
fpelliccioni edited the test plan for this revision. (Show Details)

Needs documentation.
Needs to port to CMake.
Needs some testing.

fpelliccioni abandoned this revision.Tue, Nov 19, 17:05