Page MenuHomePhabricator

Merge #15239: scripts and tools: Move non-linux build source tarballs to "bitcoin-binaries/version" directory
ClosedPublic

Authored by jasonbcox on Sep 13 2019, 21:53.

Details

Summary

5c04814b2d Move non-linux source tarball to bitcoin-binaries (Hennadii Stepanov)

Pull request description:

Currently, if a user makes a non-linux (`--os=w`, `--os=m` or `--os=wm`) gitian building with the `gitian-build.py` script, source tarballs are not moved to the `bitcoin-binaries/${VERSION}` directory.

This PR fixes this bug.

~~In addition, the `src` subdirectory in the `gitian-builder/build/out` directory is no longer used as unnecessary.~~

ACKs for commit 5c0481:

fanquake:
  utACK 5c04814
ken2812221:
  utACK 5c04814b2de179fd03ca18c19049f035a2454f81

Tree-SHA512: 8648b6cbf502c012b12642783870e37aea385bd5f4cba5cb577fee924c09685e9a117676be502e4d4783c7a8ab31a2bd495970eec42a42d78e86ac5d39323091

Backport of Core PR15239
https://github.com/bitcoin/bitcoin/pull/15239/files

Test Plan
./bitcoin-abc/contrib/gitian-build.py -c -b -o m --url /home/gitianuser/bitcoin-abc/ gitianuser pr15239
# Verify bitcoin-abc-0.20.3.tar.gz is present in ~/bitcoin-binaries/pr15239/

./bitcoin-abc/contrib/gitian-build.py -c -b -o w --url /home/gitianuser/bitcoin-abc/ gitianuser pr15239
# Verify bitcoin-abc-0.20.3.tar.gz is present in ~/bitcoin-binaries/pr15239/

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 14 2019, 16:28