Page MenuHomePhabricator
Differential D4085

Convert comments to thread safety annotations
ClosedPublic
Actions

Authored by deadalnix on Sep 14 2019, 15:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGb1ac99112da7: Convert comments to thread safety annotations
rABCb1ac99112da7: Convert comments to thread safety annotations
Summary

This is a backport of Core PR14772

Test Plan
cmake -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ..
ninja

Check that there are no thread safety analysis warnings.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14772
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7462
Build 12967: Bitcoin ABC Buildbot (legacy)
Build 12966: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 14 2019, 15:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 14 2019, 15:04
teamcity added a comment.Sep 14 2019, 15:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 14 2019, 15:12

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7462: Diff 11313.Sep 14 2019, 15:12
Fabien requested changes to this revision.Sep 14 2019, 16:36
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net.h
690

Remove, no longer needed.

This revision now requires changes to proceed.Sep 14 2019, 16:36
deadalnix updated this revision to Diff 11319.Sep 14 2019, 16:43

Remove outdated comment

Fabien accepted this revision.Sep 14 2019, 16:45
This revision is now accepted and ready to land.Sep 14 2019, 16:45
teamcity added a comment.Sep 14 2019, 16:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 14 2019, 16:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 14 2019, 16:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 14 2019, 16:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7465: Diff 11319.Sep 14 2019, 16:59
Closed by commit rABCb1ac99112da7: Convert comments to thread safety annotations (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhySep 14 2019, 17:01
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCb1ac99112da7: Convert comments to thread safety annotations.
deadalnix added a commit: rSTAGINGb1ac99112da7: Convert comments to thread safety annotations.Sep 19 2019, 02:21

Revision Contents
Changeset List

PathSize
src/
13 lines
1 line

Diff 11313

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...