Move DisconnectNodes logic to private method.
ClosedPublic
Actions

Authored by deadalnix on Sep 15 2019, 18:45.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING00e4ec254731: Move DisconnectNodes logic to private method.
rABC00e4ec254731: Move DisconnectNodes logic to private method.

Summary

This is a partical backport of Core PR14335 : https://github.com/bitcoin/bitcoin/pull/14335/commits/7479b63d9109ccaf3708a92dc65dc24556576551

Depends on D4086

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr14335-2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7470
Build 12983: Bitcoin ABC Buildbot (legacy)
Build 12982: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 15 2019, 18:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 15 2019, 18:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7470: Diff 11328.Sep 15 2019, 18:53

deadalnix added a child revision: D4088: Move InactivityCheck logic to private method..Sep 15 2019, 19:07

Fabien accepted this revision.Sep 16 2019, 07:59

This revision is now accepted and ready to land.Sep 16 2019, 07:59

Closed by commit rABC00e4ec254731: Move DisconnectNodes logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>, committed by deadalnix). · Explain WhySep 16 2019, 08:05

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC00e4ec254731: Move DisconnectNodes logic to private method..

deadalnix added a commit: rSTAGING00e4ec254731: Move DisconnectNodes logic to private method..Sep 19 2019, 02:22

Revision Contents
Changeset List

Path

Size

src/

net.h

1 line

net.cpp

123 lines

Diff 11328

View Options

src/net.h