Page MenuHomePhabricator

[contrib] Support ARM symbol check
AcceptedPublic

Authored by Fabien on Sep 16 2019, 15:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

Backport of core PR13724
https://github.com/bitcoin/bitcoin/pull/13724/files

The Risc-v section is not included as this platform is not supported.

Depends on D4185.

Test Plan

Run the linux gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13724
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7642
Build 13324: Bitcoin ABC Teamcity Staging
Build 13323: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 16 2019, 15:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2019, 15:09
Fabien planned changes to this revision.Sep 16 2019, 15:10

Will request for review after the gitian build succeeded.

Fabien added a comment.Sep 17 2019, 12:16

Do not review: this won't work with cross gcc < 7, and our gitian stretch base has only gcc 6.

Fabien updated this revision to Diff 13284.Tue, Oct 1, 12:47
Fabien edited the summary of this revision. (Show Details)

Rebase on top of D4185.

deadalnix accepted this revision.Tue, Oct 1, 18:42
deadalnix added inline comments.
contrib/devtools/symbol-check.py
50

I'm sure there is a way this can be formatted better.

This revision is now accepted and ready to land.Tue, Oct 1, 18:42