Page MenuHomePhabricator

[CMAKE] Install executables
ClosedPublic

Authored by Fabien on Sep 24 2019, 14:45.

Details

Summary

This diff adds the rules to install the built executables.

Test Plan

For all platforms:

mkdir -p buildcmake/install && cd install
cmake -GNinja .. -DCMAKE_INSTALL_PREFIX="install" # Other options

depending on the platform

ninja
ninja install

Check that the executables are installed under install/bin/.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_install_bin
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7592
Build 13224: Bitcoin ABC Buildbot (legacy)
Build 13223: arc lint + arc unit

Event Timeline

deadalnix added inline comments.
cmake/modules/InstallationHelper.cmake
5 ↗(On Diff #13113)

Why is that a macro rather than a function?

This revision is now accepted and ready to land.Sep 26 2019, 10:19
cmake/modules/InstallationHelper.cmake
5 ↗(On Diff #13113)

Because I have no need to separate the scope from the caller in this case. A function would work the same with more overhead.

This revision was automatically updated to reflect the committed changes.