Page MenuHomePhabricator
Differential D4146

[CMAKE] Install executables
ClosedPublic
Actions

Authored by Fabien on Sep 24 2019, 14:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING1010243bd5ab: [CMAKE] Install executables
rABC1010243bd5ab: [CMAKE] Install executables
Summary

This diff adds the rules to install the built executables.

Test Plan

For all platforms:

mkdir -p buildcmake/install && cd install
cmake -GNinja .. -DCMAKE_INSTALL_PREFIX="install" # Other options

depending on the platform

ninja
ninja install

Check that the executables are installed under install/bin/.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_install_bin
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7592
Build 13224: Bitcoin ABC Buildbot (legacy)
Build 13223: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 24 2019, 14:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 24 2019, 14:45
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 24 2019, 14:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7570: Diff 13113.Sep 24 2019, 14:54
teamcity added a comment.Sep 24 2019, 14:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Sep 26 2019, 10:19
deadalnix added inline comments.
cmake/modules/InstallationHelper.cmake
5 ↗(On Diff #13113)

Why is that a macro rather than a function?

This revision is now accepted and ready to land.Sep 26 2019, 10:19
Fabien added inline comments.Sep 26 2019, 11:51
cmake/modules/InstallationHelper.cmake
5 ↗(On Diff #13113)

Because I have no need to separate the scope from the caller in this case. A function would work the same with more overhead.

Fabien updated this revision to Diff 13146.Sep 26 2019, 14:32

Rebase.

teamcity added a comment.Sep 26 2019, 14:32

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 26 2019, 14:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7592: Diff 13146.Sep 26 2019, 14:47
Closed by commit rABC1010243bd5ab: [CMAKE] Install executables (authored by Fabien). · Explain WhySep 26 2019, 14:53
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC1010243bd5ab: [CMAKE] Install executables.
Fabien added a commit: rSTAGING1010243bd5ab: [CMAKE] Install executables.Sep 27 2019, 22:49

Revision Contents
Changeset List

PathSize
cmake/
modules/
12 lines
src/
7 lines
qt/
3 lines
seeder/
3 lines

Diff 13146

View Options

cmake/modules/InstallationHelper.cmake

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/qt/CMakeLists.txt

Loading...
View Options

src/seeder/CMakeLists.txt

Loading...