Page MenuHomePhabricator

Use only 3 levels for defining the version
ClosedPublic

Authored by Fabien on Tue, Sep 24, 16:01.

Details

Summary

The version is defined with 3 levels: major.minor.rev (e.g. 0.20.2).
There is an additional 4th leve defined as the build version wich is
always set to zero in our releases.
This diff removes the extra level in the version number.

Test Plan

Build on all platforms, then:

bitcoind -version
bitcoinqt -version
bitcoin-cli -version
bitcoin-tx -help

Run the gitian builds on all platforms.
Generate the man pages and check the version number has 3 levels.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Sep 24, 16:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Sep 24, 16:01
Fabien added inline comments.Tue, Sep 24, 16:07
share/setup.nsi.in
61 ↗(On Diff #13119)

Note to reviewers:
The format for windows is fixed: a.b.c.d where a, b, c, and d are 16-bit integers.
The 4th digit is forced-set to 0 for compatibility.

Fabien edited the test plan for this revision. (Show Details)Tue, Sep 24, 16:10
Fabien added inline comments.Tue, Sep 24, 17:21
share/setup.nsi.in
61 ↗(On Diff #13119)

From stackoverflow, this variable is used to set the VS_FIXEDFILEINFO structure:
https://docs.microsoft.com/fr-fr/windows/win32/api/verrsrc/ns-verrsrc-vs_fixedfileinfo?redirectedfrom=MSDN

deadalnix accepted this revision.Fri, Sep 27, 12:55
deadalnix added inline comments.
src/clientversion.h
17 ↗(On Diff #13119)

This would probably benefit from a relayout.

This revision is now accepted and ready to land.Fri, Sep 27, 12:55
Fabien updated this revision to Diff 13169.Fri, Sep 27, 13:27

Rebase and address feedback.

Fabien added inline comments.Fri, Sep 27, 13:28
src/clientversion.h
17 ↗(On Diff #13119)

Moving !defined(CLIENT_VERSION_IS_RELEASE) would have make the line 81 character long, so I moved !defined(COPYRIGHT_YEAR) instead.

This revision was automatically updated to reflect the committed changes.