Page MenuHomePhabricator
Differential D4155

[CMAKE] Fix check-security to allow running on windows executables
ClosedPublic
Actions

Authored by Fabien on Sep 26 2019, 14:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa456acd71455: [CMAKE] Fix check-security to allow running on windows executables
rABCa456acd71455: [CMAKE] Fix check-security to allow running on windows executables
Summary

From the CMake documentation:

If COMMAND specifies an executable target name (created by the
add_executable() command) it will automatically be replaced by the
location of the executable created at build time

However I was unable to make it account for the .exe extension.

This diff uses a generator expression to specify the binary by using the
full path to the executable, determined at build time.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja .. -DBUILD_BITCOIN_SEEDER=OFF \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake
ninja check-security

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_fix_check_security_windows
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7590
Build 13220: Bitcoin ABC Buildbot (legacy)
Build 13219: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 26 2019, 14:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2019, 14:04
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 26 2019, 14:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 26 2019, 14:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7590: Diff 13144.Sep 26 2019, 14:14
Fabien mentioned this in D4156: [CMAKE] Use CMake built-in to set PIC and PIE.Sep 26 2019, 14:24
deadalnix accepted this revision.Sep 27 2019, 12:53
This revision is now accepted and ready to land.Sep 27 2019, 12:53
Closed by commit rABCa456acd71455: [CMAKE] Fix check-security to allow running on windows executables (authored by Fabien). · Explain WhySep 30 2019, 10:56
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa456acd71455: [CMAKE] Fix check-security to allow running on windows executables.
Fabien mentioned this in rABC83ecf7011c1b: [CMAKE] Use CMake built-in to set PIC and PIE.
Fabien added a commit: rSTAGINGa456acd71455: [CMAKE] Fix check-security to allow running on windows executables.Oct 9 2019, 20:09
Fabien mentioned this in rSTAGING83ecf7011c1b: [CMAKE] Use CMake built-in to set PIC and PIE.

Revision Contents
Changeset List

PathSize
cmake/
modules/
4 lines

Diff 13144

View Options

cmake/modules/BinaryTest.cmake

Loading...