Page MenuHomePhabricator
Differential D4196

Minor improvements to github-release script
ClosedPublic
Actions

Authored by jasonbcox on Oct 2 2019, 00:39.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING54cbf5636d1b: Minor improvements to github-release script
rABC54cbf5636d1b: Minor improvements to github-release script
Summary

Newline and print out the link to the release page for ease-of-use.

Test Plan

./github-release.sh -a <asset dir> -o <oauth token file> -t v0.20.3 -d

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Oct 2 2019, 00:39
Herald added a reviewer: deadalnix. · View Herald TranscriptOct 2 2019, 00:39
teamcity added a comment.Oct 2 2019, 00:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 2 2019, 00:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7661: Diff 13314.Oct 2 2019, 00:49
Fabien accepted this revision.Oct 2 2019, 12:08
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/devtools/github-release.sh
161 ↗(On Diff #13314)

Nit: can be just echo

This revision is now accepted and ready to land.Oct 2 2019, 12:08
jasonbcox updated this revision to Diff 13321.Oct 2 2019, 15:51

Fix nit

teamcity added a comment.Oct 2 2019, 15:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 2 2019, 16:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7667: Diff 13321.Oct 2 2019, 16:01
Closed by commit rABC54cbf5636d1b: Minor improvements to github-release script (authored by jasonbcox). · Explain WhyOct 2 2019, 16:29
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC54cbf5636d1b: Minor improvements to github-release script.
jasonbcox mentioned this in D4195: Added a land bot script.Oct 2 2019, 16:35
jasonbcox added a commit: rSTAGING54cbf5636d1b: Minor improvements to github-release script.Oct 9 2019, 20:10

Revision Contents
Changeset List

PathSize
contrib/
devtools/
2 lines

Diff 13323

View Options

contrib/devtools/github-release.sh

Loading...