Page MenuHomePhabricator

Introduce Span type and use it instead of FLATDATA
ClosedPublic

Authored by deadalnix on Wed, Oct 2, 14:10.

Details

Summary
  • Add Slice: a (pointer, size) array view that acts like a container
  • Support serializing Span<unsigned char> and use that instead of FLATDATA

This is a backport of Core PR12886

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, Oct 2, 14:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 2, 14:10
Fabien requested changes to this revision.Thu, Oct 3, 19:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/span.h
47 ↗(On Diff #13319)

#endif // BITCOIN_SPAN_H
Linter update coming soon.

This revision now requires changes to proceed.Thu, Oct 3, 19:50
deadalnix updated this revision to Diff 13346.Thu, Oct 3, 21:41

Add header guard comment

Fabien accepted this revision.Fri, Oct 4, 06:35
This revision is now accepted and ready to land.Fri, Oct 4, 06:35