Page MenuHomePhabricator

Introduce Span type and use it instead of FLATDATA
ClosedPublic

Authored by deadalnix on Oct 2 2019, 14:10.

Details

Summary
  • Add Slice: a (pointer, size) array view that acts like a container
  • Support serializing Span<unsigned char> and use that instead of FLATDATA

This is a backport of Core PR12886

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12886
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7665
Build 13369: Bitcoin ABC Buildbot (legacy)
Build 13368: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 2 2019, 14:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2019, 14:10
Fabien requested changes to this revision.Oct 3 2019, 19:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/span.h
47

#endif // BITCOIN_SPAN_H
Linter update coming soon.

This revision now requires changes to proceed.Oct 3 2019, 19:50
deadalnix updated this revision to Diff 13346.Oct 3 2019, 21:41

Add header guard comment

Fabien accepted this revision.Oct 4 2019, 06:35
This revision is now accepted and ready to land.Oct 4 2019, 06:35