[cmake] Create a lib specifically for script related components
ClosedPublic
Actions

Authored by deadalnix on Oct 3 2019, 15:47.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING314fae5f080b: [cmake] Create a lib specifically for script related components
rABC314fae5f080b: [cmake] Create a lib specifically for script related components

Summary

This somewhat detangle the mess that the codebase is in. Most notably, sign.cpp uses part that are defined in interpreter.cpp, but there was no dependency, and it an break.

Test Plan

ninja check

Run ARM, AArch64, win32 and win64 builds.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

extractscriptlib

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7679
Build 13397: Bitcoin ABC Buildbot (legacy)
Build 13396: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 3 2019, 15:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2019, 15:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7679: Diff 13339.Oct 3 2019, 16:10

deadalnix added a child revision: D4211: Replace CombineSignatures with ProduceSignature.Oct 4 2019, 01:03

Fabien accepted this revision.Oct 4 2019, 08:30

This revision is now accepted and ready to land.Oct 4 2019, 08:30

Closed by commit rABC314fae5f080b: [cmake] Create a lib specifically for script related components (authored by deadalnix). · Explain WhyOct 4 2019, 12:13

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC314fae5f080b: [cmake] Create a lib specifically for script related components.

deadalnix added a commit: rSTAGING314fae5f080b: [cmake] Create a lib specifically for script related components.Oct 9 2019, 20:11

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

24 lines

wallet/

CMakeLists.txt

2 lines

Diff 13339

View Options

src/CMakeLists.txt