Page MenuHomePhabricator

Inline Sign1 and SignN
ClosedPublic

Authored by deadalnix on Oct 3 2019, 22:51.

Details

Summary

Sign1 and SignN are kind of redundant so remove them and inline their
behavior into SignStep

This is a partial backport of Core PR13425 : https://github.com/bitcoin/bitcoin/pull/13425/commits/b6edb4f5e6e0bf0f9c7dd26a125849f0103b44cd

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
inlinesign
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7685
Build 13409: Bitcoin ABC Buildbot (legacy)
Build 13408: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 3 2019, 22:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2019, 22:51
Fabien accepted this revision.Oct 4 2019, 08:28
This revision is now accepted and ready to land.Oct 4 2019, 08:28
This revision was automatically updated to reflect the committed changes.