Page MenuHomePhabricator
Differential D426

Fix rawtransactions.py to sign value
AbandonedPublic
Actions

Authored by deadalnix on Aug 5 2017, 17:46.

Details

Reviewers
dgenr8
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

This test was failing with SIGHASH_FORKID set because the amount was not provided for signing.

Test Plan

This is a fix to a test

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dgenr8 created this revision.Aug 5 2017, 17:46
Owners added a reviewer: Restricted Owners Package.Aug 5 2017, 17:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2017, 17:46
freetrader added a subscriber: freetrader.Aug 5 2017, 21:02

@dgenr8 : testing rawtransactions doesn't fail for me on current ABC head.
Were you testing with additional patches that then necessitate this one?

deadalnix commandeered this revision.Aug 6 2017, 14:23
deadalnix abandoned this revision.
deadalnix edited reviewers, added: dgenr8; removed: deadalnix.

Closing as I intergarted it into another patch. Thanks for that, that was hard to catch !

dgenr8 edited edge metadata.Aug 6 2017, 15:36

@freetrader The problem will show up when you change the tests to set and validate SIGHASH_FORKID.

deadalnix added a comment.Aug 6 2017, 17:29

Done as part of D430

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
2 lines

Diff 1059

View Options

qa/rpc-tests/rawtransactions.py

Loading...