Fix -Wthread-safety-analysis warnings
ClosedPublic
Actions

Authored by Fabien on Oct 23 2019, 09:58.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGdf29943217b8: Fix -Wthread-safety-analysis warnings
rABCdf29943217b8: Fix -Wthread-safety-analysis warnings

Summary

The locks were missing from D4186.

Test Plan

With Clang as a compiler:

cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug
ninja check

Ensure there is no -Wthread-safety-analysis warning in the build
output, and all the tests are passing.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 23 2019, 09:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2019, 09:58

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7840: Diff 13654.Oct 23 2019, 10:08

deadalnix accepted this revision.Oct 23 2019, 15:15

This revision is now accepted and ready to land.Oct 23 2019, 15:15

Closed by commit rABCdf29943217b8: Fix -Wthread-safety-analysis warnings (authored by Fabien). · Explain WhyOct 23 2019, 15:17

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCdf29943217b8: Fix -Wthread-safety-analysis warnings.

Fabien added a commit: rSTAGINGdf29943217b8: Fix -Wthread-safety-analysis warnings.Apr 7 2020, 21:28

Revision Contents
Changeset List

Path

Size

src/

test/

mempool_tests.cpp

16 lines

Diff 13659

View Options

src/test/mempool_tests.cpp

Fix -Wthread-safety-analysis warningsClosedPublicActions