Page MenuHomePhabricator

Fix -Wthread-safety-analysis warnings
ClosedPublic

Authored by Fabien on Oct 23 2019, 09:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCdf29943217b8: Fix -Wthread-safety-analysis warnings
Summary

The locks were missing from D4186.

Test Plan

With Clang as a compiler:

cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug
ninja check

Ensure there is no -Wthread-safety-analysis warning in the build
output, and all the tests are passing.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_thread_safety_warnings
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7840
Build 13701: Bitcoin ABC Buildbot (legacy)
Build 13700: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 23 2019, 09:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2019, 09:58
deadalnix accepted this revision.Oct 23 2019, 15:15
This revision is now accepted and ready to land.Oct 23 2019, 15:15
This revision was automatically updated to reflect the committed changes.