Page MenuHomePhabricator
Differential D428

Get rid of using namespace std in wallet/ files
ClosedPublic
Actions

Authored by freetrader on Aug 5 2017, 21:51.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGbe2108253834: Get rid of using namespace std in wallet/ files
rABCbe2108253834: Get rid of using namespace std in wallet/ files
Summary

as described

Test Plan

(configure with wallet enabled)
make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
use_std_wallet_db_cpp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 666
Build 666: arc lint + arc unit

Event Timeline

freetrader created this revision.Aug 5 2017, 21:51
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptAug 5 2017, 21:51
Harbormaster completed remote builds in B665: Diff 1062.Aug 5 2017, 21:51
freetrader updated this revision to Diff 1063.Aug 5 2017, 22:36

Add wallet RPC files which were using namespace std

Harbormaster completed remote builds in B666: Diff 1063.Aug 5 2017, 22:36
freetrader retitled this revision from Get rid of using namespace std in db.cpp to Get rid of using namespace std in wallet/ files.Aug 5 2017, 22:37
deadalnix accepted this revision.Aug 6 2017, 01:58
This revision is now accepted and ready to land.Aug 6 2017, 01:58
Closed by commit rABCbe2108253834: Get rid of using namespace std in wallet/ files (authored by freetrader, committed by freetrader). · Explain WhyAug 6 2017, 06:39
This revision was automatically updated to reflect the committed changes.
freetrader mentioned this in D394: Removed all using namespace std in wallet/.Aug 6 2017, 06:42

Revision Contents
Changeset List

PathSize
src/
wallet/
31 lines
64 lines
284 lines

Diff 1063

View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...