Page MenuHomePhabricator

[CMAKE] Build the OSX application bundle for bitcoin qt
ClosedPublic

Authored by Fabien on Thu, Oct 24, 08:29.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC27ea18e5ba99: [CMAKE] Build the OSX application bundle for bitcoin qt
Summary

When building/cross building for OSX, create an application bundle that
can run natively on OSX.
This is a first step toward generating an installer for OSX.

Test Plan

On OSX (or cross build):

ninja BitcoinABC-Qt

Check there is an app bundle (BitcoinABC-Qt.app) created under
src/qt.
Check on OSX that the bundle has the correct icon, details and can be
run.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Thu, Oct 24, 08:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Oct 24, 08:29
Fabien edited the test plan for this revision. (Show Details)Thu, Oct 24, 08:31
deadalnix requested changes to this revision.Fri, Oct 25, 15:17
deadalnix added inline comments.
src/qt/CMakeLists.txt
306 ↗(On Diff #13681)

This needs to be prepossessed by cmake, and the result of the prepossessing passed down, no?

This revision now requires changes to proceed.Fri, Oct 25, 15:17
Fabien requested review of this revision.Fri, Oct 25, 16:18
Fabien added inline comments.
src/qt/CMakeLists.txt
306 ↗(On Diff #13681)

This is done automatically by cmake.
The template file is filled with the bundle properties below, this is a facility to merge 2 commands into 1.

deadalnix accepted this revision.Tue, Oct 29, 22:51
This revision is now accepted and ready to land.Tue, Oct 29, 22:51
This revision was automatically updated to reflect the committed changes.