Page MenuHomePhabricator

[CMAKE] Build the OSX application bundle for bitcoin qt
ClosedPublic

Authored by Fabien on Oct 24 2019, 08:29.

Details

Summary

When building/cross building for OSX, create an application bundle that
can run natively on OSX.
This is a first step toward generating an installer for OSX.

Test Plan

On OSX (or cross build):

ninja BitcoinABC-Qt

Check there is an app bundle (BitcoinABC-Qt.app) created under
src/qt.
Check on OSX that the bundle has the correct icon, details and can be
run.

screenshot.png (754×512 px, 81 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_bundle_bitcoin_qt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7858
Build 13736: Bitcoin ABC Buildbot (legacy)
Build 13735: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Oct 25 2019, 15:17
deadalnix added inline comments.
src/qt/CMakeLists.txt
306

This needs to be prepossessed by cmake, and the result of the prepossessing passed down, no?

This revision now requires changes to proceed.Oct 25 2019, 15:17
Fabien requested review of this revision.Oct 25 2019, 16:18
Fabien added inline comments.
src/qt/CMakeLists.txt
306

This is done automatically by cmake.
The template file is filled with the bundle properties below, this is a facility to merge 2 commands into 1.

This revision is now accepted and ready to land.Oct 29 2019, 22:51