Update qt/sendcoinsdialog.cpp with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 22:31.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING7d6e290a69ce: Update qt/sendcoinsdialog.cpp with Qt5 connect syntax
rABC7d6e290a69ce: Update qt/sendcoinsdialog.cpp with Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-76b18bd21ccf64e256f029a8198ecdd7

Test Plan

make check
./bitcoin-qt

Open the Send menu and send some coins to yourself.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-9

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7922
Build 13854: Bitcoin ABC Buildbot (legacy)
Build 13853: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 30 2019, 22:31

Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 22:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 22:31

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7922: Diff 13805.Oct 30 2019, 22:40

deadalnix accepted this revision.Oct 31 2019, 12:32

This revision is now accepted and ready to land.Oct 31 2019, 12:32

Closed by commit rABC7d6e290a69ce: Update qt/sendcoinsdialog.cpp with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 17:20

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC7d6e290a69ce: Update qt/sendcoinsdialog.cpp with Qt5 connect syntax.

nakihito added a commit: rSTAGING7d6e290a69ce: Update qt/sendcoinsdialog.cpp with Qt5 connect syntax.Apr 7 2020, 21:33

Revision Contents
Changeset List

Path

Size

src/

qt/

sendcoinsdialog.cpp

120 lines

Diff 13805

View Options

src/qt/sendcoinsdialog.cpp

Update qt/sendcoinsdialog.cpp with Qt5 connect syntaxClosedPublicActions