Page MenuHomePhabricator

[CMAKE] Move FDELT_TYPE declaration to config
ClosedPublic

Authored by Fabien on Oct 31 2019, 21:06.

Details

Summary

This is only used when the Glibc backward compatibility feature is
enabled, but moving the definition to the bitcoin-config.h instead of
the command line has no impact on code since the glibc_compat.cpp file
(the only callsite) is built conditionally.

This fixes a weird bug in Gitian builds, where passing the
-DFDELT_TYPE="long int" definition on the command line causes GCC to
fail. While being apparently correctly surrounded by the double quotes,
the compiler sees the int as a source file and aborts. This only
occurs when the script is read from the YAML descriptor during a Gitian
build, and cannot be reproduced by building from a shell.

Test Plan
cmake -GNinja .. -DENABLE_GLIBC_BACK_COMPAT=ON
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Oct 31 2019, 21:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2019, 21:06
jasonbcox accepted this revision.Oct 31 2019, 22:30
This revision is now accepted and ready to land.Oct 31 2019, 22:30
This revision was automatically updated to reflect the committed changes.