Page MenuHomePhabricator

[CMAKE] Generate the split-debug.sh script
ClosedPublic

Authored by Fabien on Fri, Nov 1, 21:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe20d900747f1: [CMAKE] Generate the split-debug.sh script
Summary

The split-debug.sh script is generated from a template at build time,
and used by the linux gitian build to separate the debug symbols from
the stripped binaries.

Test Plan

For all the linux platforms:

cmake ..

Check the <build_dir>/contrib/devtools/split-debug.sh script is
generated as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Fri, Nov 1, 21:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 1, 21:06
Fabien updated this revision to Diff 13872.Sat, Nov 2, 08:39

Fix permissions.

deadalnix requested changes to this revision.Sat, Nov 2, 17:02
deadalnix added inline comments.
contrib/devtools/CMakeLists.txt
19 ↗(On Diff #13872)

Can you explain why this dance is necessary?

24 ↗(On Diff #13872)

Does this break deps tracking?

This revision now requires changes to proceed.Sat, Nov 2, 17:02
Fabien added inline comments.Mon, Nov 4, 08:57
contrib/devtools/CMakeLists.txt
19 ↗(On Diff #13872)

file(COPY/INSTALL) is the only cmake directive to change permissions on a file, and the script needs to be executable while the template should not.

24 ↗(On Diff #13872)

The copy will update the file and cause cmake to re-configure every time, which is not ideal. I'll fix that.

Fabien updated this revision to Diff 13884.Mon, Nov 4, 08:58

Avoid re-configuring at each call.

deadalnix accepted this revision.Thu, Nov 7, 15:12
This revision is now accepted and ready to land.Thu, Nov 7, 15:12
This revision was automatically updated to reflect the committed changes.