[CMAKE] Generate the split-debug.sh script
ClosedPublic
Actions

Authored by Fabien on Nov 1 2019, 21:06.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGe20d900747f1: [CMAKE] Generate the split-debug.sh script
rABCe20d900747f1: [CMAKE] Generate the split-debug.sh script

Summary

The split-debug.sh script is generated from a template at build time,
and used by the linux gitian build to separate the debug symbols from
the stripped binaries.

Test Plan

For all the linux platforms:

cmake ..

Check the <build_dir>/contrib/devtools/split-debug.sh script is
generated as expected.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_split_debug

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7966
Build 13935: Bitcoin ABC Buildbot (legacy)
Build 13934: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 1 2019, 21:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2019, 21:06

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7951: Diff 13867.Nov 1 2019, 21:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fix permissions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7956: Diff 13872.Nov 2 2019, 08:48

Fabien added a child revision: D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.Nov 2 2019, 11:34

deadalnix requested changes to this revision.Nov 2 2019, 17:02

deadalnix added inline comments.

contrib/devtools/CMakeLists.txt
19 ↗	(On Diff #13872)	Can you explain why this dance is necessary?
24 ↗	(On Diff #13872)	Does this break deps tracking?

This revision now requires changes to proceed.Nov 2 2019, 17:02

Fabien added inline comments.Nov 4 2019, 08:57

contrib/devtools/CMakeLists.txt
19 ↗	(On Diff #13872)	`file(COPY/INSTALL)` is the only cmake directive to change permissions on a file, and the script needs to be executable while the template should not.
24 ↗	(On Diff #13872)	The copy will update the file and cause cmake to re-configure every time, which is not ideal. I'll fix that.