Differential D4353

Tests for PSBT
ClosedPublic
Actions

Authored by deadalnix on Nov 2 2019, 01:48.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING2633916fbb90: Tests for PSBT
rABC2633916fbb90: Tests for PSBT

Summary

Added functional tests for PSBT that test the RPCs. Also added all
of the BIP 174 test vectors (except for the updater tests) in the
functional tests.

Added a Unit test for the BIP 174 updater test vector.

This is a partial backport of Core PR13557 : https://github.com/bitcoin/bitcoin/pull/13557/commits/020628e3a4e88e36647eaf92bac4b3552796ac6a

Depends on D4352

Test Plan

make check
./test/functionnal/test_runner.py rpc_psbt

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 2 2019, 01:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2019, 01:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7954: Diff 13870.Nov 2 2019, 02:00

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien requested changes to this revision.Nov 4 2019, 13:33

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/wallet/test/psbt_wallet_tests.cpp
7 ↗	(On Diff #13870)	Nit: move librairies to their own section.
12 ↗	(On Diff #13870)	Dito.
test/functional/rpc_psbt.py
16 ↗	(On Diff #13870)	Nit: put above and sort.
41 ↗	(On Diff #13870)	p2pkh and p2sh
109 ↗	(On Diff #13870)	Is this test failing ?