Page MenuHomePhabricator

Tests for PSBT
ClosedPublic

Authored by deadalnix on Sat, Nov 2, 01:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2633916fbb90: Tests for PSBT
Summary

Added functional tests for PSBT that test the RPCs. Also added all
of the BIP 174 test vectors (except for the updater tests) in the
functional tests.

Added a Unit test for the BIP 174 updater test vector.

This is a partial backport of Core PR13557 : https://github.com/bitcoin/bitcoin/pull/13557/commits/020628e3a4e88e36647eaf92bac4b3552796ac6a

Depends on D4352

Test Plan
make check
./test/functionnal/test_runner.py rpc_psbt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sat, Nov 2, 01:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Nov 2, 01:48
Fabien requested changes to this revision.Mon, Nov 4, 13:33
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/test/psbt_wallet_tests.cpp
7 ↗(On Diff #13870)

Nit: move librairies to their own section.

12 ↗(On Diff #13870)

Dito.

test/functional/rpc_psbt.py
16 ↗(On Diff #13870)

Nit: put above and sort.

41 ↗(On Diff #13870)

p2pkh and p2sh

109 ↗(On Diff #13870)

Is this test failing ?

This revision now requires changes to proceed.Mon, Nov 4, 13:33
deadalnix added inline comments.Sat, Nov 9, 16:40
test/functional/rpc_psbt.py
109 ↗(On Diff #13870)

ha yes, this is failing due to some segwit stuff, but we don't have segwit. Removing.

deadalnix updated this revision to Diff 14026.Sat, Nov 9, 16:46

Update as per comments

Fabien accepted this revision.Sat, Nov 9, 17:24
This revision is now accepted and ready to land.Sat, Nov 9, 17:24
This revision was automatically updated to reflect the committed changes.