Page MenuHomePhabricator

[CMAKE] Use native strip on OSX
ClosedPublic

Authored by Fabien on Tue, Nov 5, 09:39.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC92a22eb2564f: [CMAKE] Use native strip on OSX
Summary

This will allow for running the install/strip target when cross building
for OSX.

Test Plan
mkdir buildcmake && cd buildcmake
mkdir install
cmake -GNinja .. DCMAKE_INSTALL_PREFIX=install \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake
ninja install/strip

Check the executables are stripped (compare the size vs non stripped).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Nov 5, 09:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 5, 09:39
jasonbcox accepted this revision.Tue, Nov 5, 16:37
This revision is now accepted and ready to land.Tue, Nov 5, 16:37
This revision was automatically updated to reflect the committed changes.