Page MenuHomePhabricator

[CI] Allow to pass addditional arguments to bitcoind
Needs RevisionPublic

Authored by Fabien on Fri, Nov 8, 20:53.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

This will allow to pass the -dbcache option to bitcoind, which is expected to speedup IBD on machines with larger memory capacity.

Test Plan

On a machine with at least 16GB of RAM:

export ABC_BUILD_NAME=build-ibd
export BITCOIND_EXTRA_ARGS="-dbcache=15000"
./contrib/teamcity/build-configurations.sh

Sanity check:

export ABC_BUILD_NAME=build-ibd ./contrib/teamcity/build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ci_dbcache
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8044
Build 14083: Bitcoin ABC Buildbot
Build 14082: arc lint + arc unit

Event Timeline

Fabien created this revision.Fri, Nov 8, 20:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 8, 20:53
jasonbcox requested changes to this revision.Fri, Nov 8, 21:01
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/build-configurations.sh
120 ↗(On Diff #14011)

Won't this error when DBCACHE isn't set? (Due to not being defined)

Either way, add the default to the test plan.

This revision now requires changes to proceed.Fri, Nov 8, 21:01
Fabien added a comment.Sat, Nov 9, 09:31

Yes good catch I forgot the set -u !

Fabien edited the test plan for this revision. (Show Details)Sat, Nov 9, 09:31
Fabien retitled this revision from [CI] Allow to override the dbcache value to [CI] Allow to pass addditional arguments to bitcoind.Sat, Nov 9, 09:46
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)
Fabien updated this revision to Diff 14024.Sat, Nov 9, 09:50

Generalize to make passing other options available beside dbcache.
Take the set -u into account...

deadalnix requested changes to this revision.Sun, Nov 10, 16:01
deadalnix added inline comments.
contrib/teamcity/build-configurations.sh
123

It does looks like these args are only passed down to IBD, not bitcoind in general. For instance, they do not get passed down integration tests.

This revision now requires changes to proceed.Sun, Nov 10, 16:01