Page MenuHomePhabricator

[CI] Allow to pass addditional arguments to bitcoind
Changes PlannedPublic

Authored by Fabien on Nov 8 2019, 20:53.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

This will allow to pass the -dbcache option to bitcoind, which is expected to speedup IBD on machines with larger memory capacity.

Test Plan

On a machine with at least 16GB of RAM:

export ABC_BUILD_NAME=build-ibd
export IBD_BITCOIND_EXTRA_ARGS="-dbcache=15000"
./contrib/teamcity/build-configurations.sh

Sanity check:

export ABC_BUILD_NAME=build-ibd ./contrib/teamcity/build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ci_dbcache
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8072
Build 14134: Bitcoin ABC Buildbot (legacy)
Build 14133: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 8 2019, 20:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 8 2019, 20:53
jasonbcox requested changes to this revision.Nov 8 2019, 21:01
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/build-configurations.sh
120 ↗(On Diff #14011)

Won't this error when DBCACHE isn't set? (Due to not being defined)

Either way, add the default to the test plan.

This revision now requires changes to proceed.Nov 8 2019, 21:01
Fabien added a comment.Nov 9 2019, 09:31

Yes good catch I forgot the set -u !

Fabien edited the test plan for this revision. (Show Details)Nov 9 2019, 09:31
Fabien retitled this revision from [CI] Allow to override the dbcache value to [CI] Allow to pass addditional arguments to bitcoind.Nov 9 2019, 09:46
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)
Fabien updated this revision to Diff 14024.Nov 9 2019, 09:50

Generalize to make passing other options available beside dbcache.
Take the set -u into account...

deadalnix requested changes to this revision.Nov 10 2019, 16:01
deadalnix added inline comments.
contrib/teamcity/build-configurations.sh
123 ↗(On Diff #14024)

It does looks like these args are only passed down to IBD, not bitcoind in general. For instance, they do not get passed down integration tests.

This revision now requires changes to proceed.Nov 10 2019, 16:01
Fabien edited the test plan for this revision. (Show Details)Nov 12 2019, 09:50
Fabien updated this revision to Diff 14069.Nov 12 2019, 09:51

Update variable name to better reflect the intent.

deadalnix requested changes to this revision.Nov 23 2019, 15:26
This revision now requires changes to proceed.Nov 23 2019, 15:26
deadalnix accepted this revision.Nov 23 2019, 15:27

I'm not sure why so much parameters are passed down as environment variables, that sounds fragile to me.

This revision now requires review to proceed.Nov 23 2019, 15:27
Fabien planned changes to this revision.Dec 4 2019, 16:54