Page MenuHomePhabricator
Differential D4421

Swap in descriptors support into scantxoutset
ClosedPublic
Actions

Authored by deadalnix on Nov 9 2019, 22:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGda453ae29215: Swap in descriptors support into scantxoutset
rABCda453ae29215: Swap in descriptors support into scantxoutset
Summary

This is a partial backport of Core PR13697 : https://github.com/bitcoin/bitcoin/pull/13697/commits/151600bb4972f7bab4ed4a03d1f67c38e081fefe

Also includes:

Depends on D4357 and D4420

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13697
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8050
Build 14095: Bitcoin ABC Buildbot (legacy)
Build 14094: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 9 2019, 22:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2019, 22:53
teamcity added a comment.Nov 9 2019, 22:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4422: Add descriptor reference documentation.Nov 9 2019, 22:59
teamcity added a comment.Nov 9 2019, 23:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8050: Diff 14034.Nov 9 2019, 23:03
Fabien requested changes to this revision.Nov 11 2019, 14:47
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
2403

Braces

2411

Braces

2428

Braces

This revision now requires changes to proceed.Nov 11 2019, 14:47
deadalnix updated this revision to Diff 14071.Nov 12 2019, 13:33

Add braces

teamcity added a comment.Nov 12 2019, 13:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 12 2019, 13:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8073: Diff 14071.Nov 12 2019, 13:46
Fabien accepted this revision.Nov 12 2019, 13:58
This revision is now accepted and ready to land.Nov 12 2019, 13:58
Closed by commit rABCda453ae29215: Swap in descriptors support into scantxoutset (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyNov 12 2019, 14:35
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCda453ae29215: Swap in descriptors support into scantxoutset.
deadalnix added a commit: rSTAGINGda453ae29215: Swap in descriptors support into scantxoutset.Apr 7 2020, 21:40

Revision Contents
Changeset List

PathSize
src/
rpc/
218 lines
script/
1 line
6 lines
test/
18 lines
test/
functional/
112 lines

Diff 14034

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/script/descriptor.h

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

src/test/descriptor_tests.cpp

Loading...
View Options

test/functional/rpc_scantxoutset.py

Loading...