Page MenuHomePhabricator

Add outputtype module

Authored by deadalnix on Nov 11 2019, 01:03.



Moves OutputType into its own module

  • Move AddAndGetDestinationForScript from wallet to outputype module

Makes AddAndGetDestinationForScript use a generic CKeyStore rather than
the wallet, and makes it always add the script to the keystore, rather
than only adding related (redeem) scripts.

  • segwit support for createmultisig RPC
  • [tests] functional test for createmultisig RPC

This is a backport of Core PR13072

Depends on D4423

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Nov 11 2019, 01:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2019, 01:03
Fabien added a subscriber: Fabien.Nov 12 2019, 07:33

What is the purpose of the OutputType for us, intended that we don't do segwit ?

It's not super useful, ut helps backports.

Fabien requested changes to this revision.Nov 14 2019, 15:58
Fabien added inline comments.
21 ↗(On Diff #14076)

Despite somewhat documented in a couple places, there is no such option in our codebase.

26 ↗(On Diff #14076)


49 ↗(On Diff #14076)

Nit: spaces around operators

52 ↗(On Diff #14076)


This revision now requires changes to proceed.Nov 14 2019, 15:58
deadalnix updated this revision to Diff 14160.Nov 16 2019, 13:37

Address comments

deadalnix added inline comments.Nov 16 2019, 14:46
49 ↗(On Diff #14076)

I'm not sure what you want me to do here.

Fabien added inline comments.Nov 16 2019, 22:10
49 ↗(On Diff #14076)

It's just style nit, I want you to surround the operators with spaces, e.g. here:
total = 149 * 50 + (height - 149 - 100) * 25

I'll see if there is a way to tell autopep8 to do it automatically, but I think I did already search for this feature with no success.

deadalnix updated this revision to Diff 14165.Nov 17 2019, 22:19

Add spaces

Fabien accepted this revision.Nov 18 2019, 08:11
This revision is now accepted and ready to land.Nov 18 2019, 08:11
This revision was automatically updated to reflect the committed changes.