Page MenuHomePhabricator

[CMAKE] Use a stripped binary to build the dist and DMG for OSX
ClosedPublic

Authored by Fabien on Nov 13 2019, 14:39.

Details

Summary

This diff creates a copy of the bitcoin-qt application bundle on OSX,
and strip the executable inside.
This stripped version is then use to build the DMG image.

Depends on D4437.

Test Plan

Build for OSX:

ninja osx-dmg

Check there is a src/qt/stripped directory containing a copy of the
bundle with a stripped binary inside.
Check the dist and DMG binary is stripped.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Nov 17 2019, 22:46
src/qt/CMakeLists.txt
362 ↗(On Diff #14102)

This seems kinda inefficient, but we'll see in practice if this is a problem. There is already much worse problems tracking dependencies on OSX, so I don't think we should worry about this unless it prove to be a problem.