Differential D4447

RPC: Add new getzmqnotifications method.
ClosedPublic
Actions

Authored by Fabien on Nov 14 2019, 16:22.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING5df3c1d33e94: RPC: Add new getzmqnotifications method.
rABC5df3c1d33e94: RPC: Add new getzmqnotifications method.

Summary

This adds a new RPC method "getzmqnotifications", which returns
information about all active ZMQ notification endpoints.  This is useful
for software that layers on top of bitcoind, so it can verify that
ZeroMQ is enabled and also figure out where it should listen.

Backport of core PR13570 and PR13645:
https://github.com/bitcoin/bitcoin/pull/13570/files
https://github.com/bitcoin/bitcoin/pull/13645/files

Test Plan

make check

Run 3 times:

test_runner.py rpc_zmq

First time with zmq all on, should pass
Second time after uninstalling python3-zmq, should skip (reinstall

after :))

Third time after disabling zmq (with configure or cmake), should skip

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13570

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

Fabien created this revision.Nov 14 2019, 16:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 14 2019, 16:22

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B8114: Diff 14131.Nov 14 2019, 16:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien added a child revision: D4450: qa: Premine to deterministic address with -disablewallet.Nov 15 2019, 09:13

deadalnix accepted this revision.Nov 17 2019, 23:22

deadalnix added inline comments.

src/init.cpp
273	This calls for a unique_ptr, but out of the scope of this patch.

This revision is now accepted and ready to land.Nov 17 2019, 23:22

Closed by commit rABC5df3c1d33e94: RPC: Add new getzmqnotifications method. (authored by Daniel Kraft <d@domob.eu>, committed by Fabien). · Explain WhyNov 19 2019, 14:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5df3c1d33e94: RPC: Add new getzmqnotifications method..

Fabien added a commit: rSTAGING5df3c1d33e94: RPC: Add new getzmqnotifications method..Apr 7 2020, 21:43

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

2 lines

src/

6 lines

22 lines

zmq/

1 line

zmqnotificationinterface.h

6 lines

zmqnotificationinterface.cpp

13 lines

12 lines

62 lines

test/

functional/

interface_zmq.py

22 lines

40 lines

test_framework/

test_framework.py

17 lines

lint/

check-rpc-mappings.py

1 line

Diff 14131

doc/release-notes.md

Loading...

src/Makefile.am

Loading...

src/init.cpp

Loading...

src/zmq/CMakeLists.txt

Loading...

src/zmq/zmqnotificationinterface.h

Loading...

src/zmq/zmqnotificationinterface.cpp

Loading...

src/zmq/zmqrpc.h

Loading...

src/zmq/zmqrpc.cpp

Loading...

test/functional/interface_zmq.py

Loading...

test/functional/rpc_zmq.py

Loading...

test/functional/test_framework/test_framework.py

Loading...

test/lint/check-rpc-mappings.py

Loading...