Page MenuHomePhabricator
Differential D4472

Remove obj_c for macOS Dock icon setting
ClosedPublic
Actions

Authored by Fabien on Nov 19 2019, 16:24.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa0a2b7ce7a5c: Remove obj_c for macOS Dock icon setting
rABCa0a2b7ce7a5c: Remove obj_c for macOS Dock icon setting
Summary
Qt `setWindowIcon()` does this work.

Partial backport of core PR14123 (commit 53bb6be):
https://github.com/bitcoin/bitcoin/pull/14123/commits/53bb6be3f8a50ee9e5c4d7e9155236152e7c4b7c

Test Plan

Build for OSX and run bitcoin-qt.
Check the dock icon shows up and the show/hide feature is working.
Tested on OSX Catalina.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 19 2019, 16:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2019, 16:24
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 19 2019, 16:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 19 2019, 16:34

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8160: Diff 14205.Nov 19 2019, 16:34
deadalnix accepted this revision.Nov 19 2019, 23:34
This revision is now accepted and ready to land.Nov 19 2019, 23:34
Fabien added a child revision: D4480: Use Qt signal for macOS Dock icon click event.Nov 20 2019, 08:38
Closed by commit rABCa0a2b7ce7a5c: Remove obj_c for macOS Dock icon setting (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyNov 20 2019, 08:43
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa0a2b7ce7a5c: Remove obj_c for macOS Dock icon setting.
Fabien removed a child revision: D4480: Use Qt signal for macOS Dock icon click event.Nov 20 2019, 08:49
Fabien added a commit: rSTAGINGa0a2b7ce7a5c: Remove obj_c for macOS Dock icon setting.Apr 7 2020, 21:43

Revision Contents
Changeset List

PathSize
src/
qt/
4 lines
2 lines
35 lines

Diff 14219

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/macdockiconhandler.h

Loading...
View Options

src/qt/macdockiconhandler.mm

Loading...