Page MenuHomePhabricator
Differential D4490

Generalize PublicOnlySigningProvider into HidingSigningProvider
ClosedPublic
Actions

Authored by deadalnix on Nov 20 2019, 16:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING93aa869bfd7e: Generalize PublicOnlySigningProvider into HidingSigningProvider
rABC93aa869bfd7e: Generalize PublicOnlySigningProvider into HidingSigningProvider
Summary

This is a partial backport of Core PR13723 : https://github.com/bitcoin/bitcoin/pull/13723/commits/81e1dd5ce1a32114a38691ec6b55e72ab04dbbb1

Depends on D4489

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 20 2019, 16:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 16:26
teamcity added a comment.Nov 20 2019, 16:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4491: Implement key origin lookup in CWallet.Nov 20 2019, 16:30
teamcity added a comment.Nov 20 2019, 16:36

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8182: Diff 14239!Nov 20 2019, 16:36
teamcity added a comment.Nov 20 2019, 20:07

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 20 2019, 20:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8182: Diff 14239.Nov 20 2019, 20:18
Fabien accepted this revision.Nov 21 2019, 20:00
This revision is now accepted and ready to land.Nov 21 2019, 20:00
Closed by commit rABC93aa869bfd7e: Generalize PublicOnlySigningProvider into HidingSigningProvider (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyNov 21 2019, 23:06
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC93aa869bfd7e: Generalize PublicOnlySigningProvider into HidingSigningProvider.
deadalnix added a commit: rSTAGING93aa869bfd7e: Generalize PublicOnlySigningProvider into HidingSigningProvider.Apr 7 2020, 21:47

Revision Contents
Changeset List

PathSize
src/
script/
17 lines
22 lines
wallet/
10 lines

Diff 14307

View Options

src/script/sign.h

Loading...
View Options

src/script/sign.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...