Don't use systray icon on inappropriate systems
ClosedPublic
Actions

Authored by Fabien on Nov 20 2019, 16:54.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING2ff3c7cb1c4c: Don't use systray icon on inappropriate systems
rABC2ff3c7cb1c4c: Don't use systray icon on inappropriate systems

Summary

Prevent a user from losing access to the main window by minimizing it to
the tray on some systems (e.g. GNOME 3.26+).

Backport of core PR14228 and PR15000:
https://github.com/bitcoin/bitcoin/pull/14228/files
https://github.com/bitcoin/bitcoin/pull/15000/files

Test Plan

Build and run on a Linux with a trayless DE.
Check the behavior against the summary.
Send some coins to yourself and check the notifications are popping.
Tested on Buster w/ Gnome shell.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 20 2019, 16:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 16:54

Herald added a reviewer: deadalnix. · View Herald Transcript

deadalnix accepted this revision.Nov 20 2019, 17:53

This revision is now accepted and ready to land.Nov 20 2019, 17:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8186: Diff 14250.Nov 20 2019, 18:31

Closed by commit rABC2ff3c7cb1c4c: Don't use systray icon on inappropriate systems (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyNov 21 2019, 08:31

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2ff3c7cb1c4c: Don't use systray icon on inappropriate systems.

Fabien added a commit: rSTAGING2ff3c7cb1c4c: Don't use systray icon on inappropriate systems.Apr 7 2020, 21:46

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.cpp

17 lines

optionsdialog.cpp

14 lines

Diff 14283

View Options

src/qt/bitcoingui.cpp