Page MenuHomePhabricator
Differential D4492

Don't use systray icon on inappropriate systems
ClosedPublic
Actions

Authored by Fabien on Nov 20 2019, 16:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2ff3c7cb1c4c: Don't use systray icon on inappropriate systems
rABC2ff3c7cb1c4c: Don't use systray icon on inappropriate systems
Summary
Prevent a user from losing access to the main window by minimizing it to
the tray on some systems (e.g. GNOME 3.26+).

Backport of core PR14228 and PR15000:
https://github.com/bitcoin/bitcoin/pull/14228/files
https://github.com/bitcoin/bitcoin/pull/15000/files

Test Plan

Build and run on a Linux with a trayless DE.
Check the behavior against the summary.
Send some coins to yourself and check the notifications are popping.
Tested on Buster w/ Gnome shell.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14228
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8186
Build 14400: Default Diff Build & Tests
Build 14399: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
qt/
17 lines
14 lines

Diff 14250

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/optionsdialog.cpp

Loading...