Page MenuHomePhabricator

Don't use systray icon on inappropriate systems
ClosedPublic

Authored by Fabien on Nov 20 2019, 16:54.

Details

Summary
Prevent a user from losing access to the main window by minimizing it to
the tray on some systems (e.g. GNOME 3.26+).

Backport of core PR14228 and PR15000:
https://github.com/bitcoin/bitcoin/pull/14228/files
https://github.com/bitcoin/bitcoin/pull/15000/files

Test Plan

Build and run on a Linux with a trayless DE.
Check the behavior against the summary.
Send some coins to yourself and check the notifications are popping.
Tested on Buster w/ Gnome shell.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14228
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8186
Build 14400: Default Diff Build & Tests
Build 14399: arc lint + arc unit