Page MenuHomePhabricator
Differential D4498

Update valid PSBT test vectors so that they properly use the value 0 for utxos's key
ClosedPublic
Actions

Authored by deadalnix on Nov 21 2019, 11:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGe6c6db649672: Update valid PSBT test vectors so that they properly use the value 0 for…
rABCe6c6db649672: Update valid PSBT test vectors so that they properly use the value 0 for…
Summary

As per title, some of them still used 1, which stands for witness utxo that we do not support. However, due to unknown value being forwarded, it ended up working - but not testing what we expect.

Test Plan
./test/functional/test_runner.py rpc_psbt.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
psbtwitness
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8209
Build 14444: Default Diff Build & Tests
Build 14443: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 21 2019, 11:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2019, 11:24
teamcity added a comment.Nov 21 2019, 11:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 21 2019, 11:30

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8209: Diff 14285!Nov 21 2019, 11:30
deadalnix updated this revision to Diff 14300.Nov 21 2019, 17:19

Rebase and run the test suite

teamcity added a comment.Nov 21 2019, 17:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 21 2019, 17:33

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8218: Diff 14300.Nov 21 2019, 17:33
Fabien accepted this revision.Nov 21 2019, 18:18
This revision is now accepted and ready to land.Nov 21 2019, 18:18
Closed by commit rABCe6c6db649672: Update valid PSBT test vectors so that they properly use the value 0 for… (authored by deadalnix). · Explain WhyNov 21 2019, 22:56
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCe6c6db649672: Update valid PSBT test vectors so that they properly use the value 0 for….
deadalnix added a commit: rSTAGINGe6c6db649672: Update valid PSBT test vectors so that they properly use the value 0 for….Apr 7 2020, 21:46

Revision Contents
Changeset List

PathSize
test/
functional/
data/
4 lines

Diff 14285

View Options

test/functional/data/rpc_psbt.json

Loading...