Differential D4512

Use RdSeed when available, and reduce RdRand load
ClosedPublic
Actions

Authored by deadalnix on Nov 22 2019, 20:56.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING4b204154096a: Use RdSeed when available, and reduce RdRand load
rABC4b204154096a: Use RdSeed when available, and reduce RdRand load

Summary

This introduces support for autodetecting and using the RdSeed instruction.

In addition:

In SeedFast, only 64 bits of entropy are generated through RdRand (256 was relatively slow).
In SeedStartup, 256 bits of entropy are generated, using RdSeed (preferably) or RdRand (otherwise).

This is a backport of Core PR15250

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15250

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8236
Build 14498: Default Diff Build & Tests
Build 14497: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 22 2019, 20:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2019, 20:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8236: Diff 14335!Nov 22 2019, 21:08

Fabien requested changes to this revision.Nov 24 2019, 10:26

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/random.cpp
142	Move the comment above. The same apply to all other similar changes in the diff.
143	Braces. The same apply to all other similar changes in the diff.
150	Use c++ constructor
179	TIL the pause instruction
187	Use C++ constructor
215	Layout

This revision now requires changes to proceed.Nov 24 2019, 10:26

fix various style things

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8256: Diff 14360.Nov 24 2019, 22:32

Fabien accepted this revision.Nov 25 2019, 07:07

This revision is now accepted and ready to land.Nov 25 2019, 07:07

Closed by commit rABC4b204154096a: Use RdSeed when available, and reduce RdRand load (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyNov 25 2019, 13:27

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC4b204154096a: Use RdSeed when available, and reduce RdRand load.

deadalnix added a commit: rSTAGING4b204154096a: Use RdSeed when available, and reduce RdRand load.Apr 7 2020, 21:48

Revision Contents
Changeset List

Path

Size

src/

3 lines

196 lines

Diff 14335

src/random.h

Loading...

src/random.cpp

Loading...