Page MenuHomePhabricator

[cmake] Add comments to express what tests do.
ClosedPublic

Authored by deadalnix on Mon, Nov 25, 17:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC82df9cb4a4fc: [cmake] Add comments to express what tests do.
Summary

The current way of having an echo command before running the test is rather pointless as the echo is only rendered once the test finishes. Presumably, the author of these echo command intended to use the COMMENT directive.

Test Plan
ninja check-bitcoin-util
ninja check-rpcauth
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Mon, Nov 25, 17:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 25, 17:03
Fabien accepted this revision.Mon, Nov 25, 17:09
This revision is now accepted and ready to land.Mon, Nov 25, 17:09
This revision was landed with ongoing or failed builds.Mon, Nov 25, 17:58
This revision was automatically updated to reflect the committed changes.