Page MenuHomePhabricator

[cmake] Add comments to express what tests do.
ClosedPublic

Authored by deadalnix on Nov 25 2019, 17:03.

Details

Summary

The current way of having an echo command before running the test is rather pointless as the echo is only rendered once the test finishes. Presumably, the author of these echo command intended to use the COMMENT directive.

Test Plan
ninja check-bitcoin-util
ninja check-rpcauth
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmaketestcomment
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8265
Build 14555: Default Diff Build & Tests
Build 14554: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Nov 25 2019, 17:09
This revision was landed with ongoing or failed builds.Nov 25 2019, 17:58
This revision was automatically updated to reflect the committed changes.