Use BlockHash in BlockTransactionsRequest
ClosedPublic
Actions

Authored by deadalnix on Nov 30 2019, 22:35.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING3c003d3d2bb7: Use BlockHash in BlockTransactionsRequest
rABC3c003d3d2bb7: Use BlockHash in BlockTransactionsRequest

Summary

It's the correct thing to do and all sites that use are already doing the right thing.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

blockencodingblockhash

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8358
Build 14735: Default Diff Build & Tests
Build 14734: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 30 2019, 22:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2019, 22:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8358: Diff 14541.Nov 30 2019, 22:50

Fabien accepted this revision.Dec 2 2019, 08:06

This revision is now accepted and ready to land.Dec 2 2019, 08:06

Closed by commit rABC3c003d3d2bb7: Use BlockHash in BlockTransactionsRequest (authored by deadalnix). · Explain WhyDec 2 2019, 14:10

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC3c003d3d2bb7: Use BlockHash in BlockTransactionsRequest.

deadalnix added a commit: rSTAGING3c003d3d2bb7: Use BlockHash in BlockTransactionsRequest.Apr 7 2020, 21:57

Revision Contents
Changeset List

Path

Size

src/

blockencodings.h

2 lines

Diff 14541

View Options

Use BlockHash in BlockTransactionsRequestClosedPublicActions