Fix a bug where test-autopatch would fail in an env where no global git config is set
ClosedPublic
Actions

Authored by jasonbcox on Dec 4 2019, 18:49.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING15ed531cdf64: Fix a bug where test-autopatch would fail in an env where no global git config…
rABC15ed531cdf64: Fix a bug where test-autopatch would fail in an env where no global git config…

Summary

See title.

Test Plan

In environments with and without global git config set:
ninja check-source-control-tools

Diff Detail

Repository

rABC Bitcoin ABC

Branch

aptest-git-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8409
Build 14835: Default Diff Build & Tests
Build 14834: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 4 2019, 18:49

Herald added a reviewer: deadalnix. · View Herald TranscriptDec 4 2019, 18:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8409: Diff 14620.Dec 4 2019, 19:00

As it turns out, having test that depends on the user's global config, not testing the actual software but running by default on the software test suite.

This revision is now accepted and ready to land.Dec 4 2019, 23:25

Closed by commit rABC15ed531cdf64: Fix a bug where test-autopatch would fail in an env where no global git config… (authored by jasonbcox). · Explain WhyDec 5 2019, 17:04

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC15ed531cdf64: Fix a bug where test-autopatch would fail in an env where no global git config….

jasonbcox added a commit: rSTAGING15ed531cdf64: Fix a bug where test-autopatch would fail in an env where no global git config….Apr 7 2020, 21:59

Revision Contents
Changeset List

Path

Size

contrib/

source-control-tools/

test/

test-autopatch.sh

5 lines

Diff 14620

View Options

contrib/source-control-tools/test/test-autopatch.sh

Fix a bug where test-autopatch would fail in an env where no global git config is setClosedPublicActions