unsigned char -> uint8_t and remove using namespace std
AbandonedPublic
Actions

Authored by CCulianu on Aug 10 2017, 15:32.

Details

Reviewers

freetrader
deadalnix

Group Reviewers

Restricted Project

Summary

Note this also went through the linter -- actual changes are only a few lines to clean up string -> std::string and to make unsigned char -> uint8_t

Finish cleaning up code, in the spirit of other commits

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

unival

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 722
Build 722: arc lint + arc unit

Event Timeline

CCulianu created this revision.Aug 10 2017, 15:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 10 2017, 15:32

CCulianu edited the summary of this revision. (Show Details)Aug 10 2017, 15:34

CCulianu edited the summary of this revision. (Show Details)

No please don't change univalue. This is a project of its own.

This revision now requires changes to proceed.Aug 10 2017, 16:09

Revision Contents
Changeset List

Path

Size

src/

univalue/

lib/

univalue.cpp

225 lines

univalue_read.cpp

535 lines

univalue_write.cpp

107 lines

test/

unitester.cpp

170 lines

Diff 1154

View Options

src/univalue/lib/univalue.cpp

View Options

src/univalue/lib/univalue_read.cpp

View Options

src/univalue/lib/univalue_write.cpp

View Options

src/univalue/test/unitester.cpp

unsigned char -> uint8_t and remove using namespace stdAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1154

src/univalue/lib/univalue.cpp

src/univalue/lib/univalue_read.cpp

src/univalue/lib/univalue_write.cpp

src/univalue/test/unitester.cpp

unsigned char -> uint8_t and remove using namespace std
AbandonedPublic
Actions

Revision Contents
Changeset List