Remove check-source-control-tools from check and check-all targets
ClosedPublic
Actions

Authored by deadalnix on Dec 5 2019, 13:17.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING2da49591e709: Remove check-source-control-tools from check and check-all targets
rABC2da49591e709: Remove check-source-control-tools from check and check-all targets

Summary

It bugguy, it depends on machine state and setup, it doesn't test the software and it bloats output.

This should never have been part of the test suite to begin with and the past 2 days have made it very clear.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 5 2019, 13:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 5 2019, 13:17

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Dec 5 2019, 13:18

This revision is now accepted and ready to land.Dec 5 2019, 13:18

This revision was landed with ongoing or failed builds.Dec 5 2019, 13:19

Closed by commit rABC2da49591e709: Remove check-source-control-tools from check and check-all targets (authored by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC2da49591e709: Remove check-source-control-tools from check and check-all targets.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8423: Diff 14639.Dec 5 2019, 13:37

deadalnix added a commit: rSTAGING2da49591e709: Remove check-source-control-tools from check and check-all targets.Apr 7 2020, 21:59

Revision Contents
Changeset List

Path

Size

contrib/

source-control-tools/

CMakeLists.txt

2 lines

Diff 14640

View Options

contrib/source-control-tools/CMakeLists.txt

Remove check-source-control-tools from check and check-all targetsClosedPublicActions